[HUDI-7549] Reverting spurious log block deduction with LogRecordReader #10922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
changed the title
yihua
requested changes
Mar 25, 2024
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
Show resolved
Hide resolved
|
@nsivabalan could you check the CI failures? |
nsivabalan
force-pushed
the
revertSpuriousLogBlocksDetectionPatch
branch
2 times, most recently
from
7619816
to
41e7049
Compare
yihua
force-pushed
the
revertSpuriousLogBlocksDetectionPatch
branch
from
41e7049
to
1c36f92
Compare
yihua
approved these changes
May 13, 2024
jonvex
reviewed
May 13, 2024
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
Show resolved
Hide resolved
yihua
force-pushed
the
revertSpuriousLogBlocksDetectionPatch
branch
from
1c36f92
to
802eeb7
Compare
|
Azure CI is green. |
yihua
added a commit
that referenced
this pull request
May 15, 2024
…er (#10922) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
yihua
added a commit
that referenced
this pull request
May 15, 2024
…er (#10922) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
yihua
added a commit
that referenced
this pull request
May 15, 2024
…er (#10922) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
We added support to deduce spurious log blocks with log block reader (#9545 and #9611 ) in 0.14.0.
Apparently there are some cases where it could lead to data loss or data consistency issues.
#9611 (comment)
So, we are reverting the changes for now until we have a thorough patch where we can deduce such spurious log blocks.
Impact
No data consistency issues w/ log record reader.
Risk level (write none, low medium or high below)
medium
Documentation Update
none
Contributor's checklist